Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd3193e1 authored by Ivo van Doorn's avatar Ivo van Doorn Committed by David S. Miller
Browse files

rt2x00: Cleanup write_tx_desc() arguments 



Send the skb structure with write_tx_desc() and use
the skbdesc structure to read all information about
the frame. This saves several arguments in the function
definition and it is easier to send more information
later as well.

Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 3c4f2085

drivers/net/wireless/rt2x00/rt2400pci.c

+4 −4
Original line number Diff line number Diff line
@@ -1012,19 +1012,19 @@ static int rt2400pci_set_device_state(struct rt2x00_dev *rt2x00dev, 
 * TX descriptor initialization

 */

static void rt2400pci_write_tx_desc(struct rt2x00_dev *rt2x00dev,

				    __le32 *txd,

				    struct sk_buff *skb,

				    struct txdata_entry_desc *desc,

				    struct ieee80211_hdr *ieee80211hdr,

				    unsigned int length,

				    struct ieee80211_tx_control *control)

{

	struct skb_desc *skbdesc = get_skb_desc(skb);

	__le32 *txd = skbdesc->desc;

	u32 word;



	/*

	 * Start writing the descriptor words.

	 */

	rt2x00_desc_read(txd, 2, &word);

	rt2x00_set_field32(&word, TXD_W2_DATABYTE_COUNT, length);

	rt2x00_set_field32(&word, TXD_W2_DATABYTE_COUNT, skbdesc->data_len);

	rt2x00_desc_write(txd, 2, word);



	rt2x00_desc_read(txd, 3, &word);

drivers/net/wireless/rt2x00/rt2500pci.c

+4 −4
Original line number Diff line number Diff line
@@ -1162,12 +1162,12 @@ static int rt2500pci_set_device_state(struct rt2x00_dev *rt2x00dev, 
 * TX descriptor initialization

 */

static void rt2500pci_write_tx_desc(struct rt2x00_dev *rt2x00dev,

				    __le32 *txd,

				    struct sk_buff *skb,

				    struct txdata_entry_desc *desc,

				    struct ieee80211_hdr *ieee80211hdr,

				    unsigned int length,

				    struct ieee80211_tx_control *control)

{

	struct skb_desc *skbdesc = get_skb_desc(skb);

	__le32 *txd = skbdesc->desc;

	u32 word;



	/*
@@ -1208,7 +1208,7 @@ static void rt2500pci_write_tx_desc(struct rt2x00_dev *rt2x00dev, 
	rt2x00_set_field32(&word, TXD_W0_RETRY_MODE,

			   !!(control->flags &

			      IEEE80211_TXCTL_LONG_RETRY_LIMIT));

	rt2x00_set_field32(&word, TXD_W0_DATABYTE_COUNT, length);

	rt2x00_set_field32(&word, TXD_W0_DATABYTE_COUNT, skbdesc->data_len);

	rt2x00_set_field32(&word, TXD_W0_CIPHER_ALG, CIPHER_NONE);

	rt2x00_desc_write(txd, 0, word);

}

drivers/net/wireless/rt2x00/rt2500usb.c

+4 −4
Original line number Diff line number Diff line
@@ -1024,12 +1024,12 @@ static int rt2500usb_set_device_state(struct rt2x00_dev *rt2x00dev, 
 * TX descriptor initialization

 */

static void rt2500usb_write_tx_desc(struct rt2x00_dev *rt2x00dev,

				    __le32 *txd,

				    struct sk_buff *skb,

				    struct txdata_entry_desc *desc,

				    struct ieee80211_hdr *ieee80211hdr,

				    unsigned int length,

				    struct ieee80211_tx_control *control)

{

	struct skb_desc *skbdesc = get_skb_desc(skb);

	__le32 *txd = skbdesc->desc;

	u32 word;



	/*
@@ -1062,7 +1062,7 @@ static void rt2500usb_write_tx_desc(struct rt2x00_dev *rt2x00dev, 
	rt2x00_set_field32(&word, TXD_W0_NEW_SEQ,

			   !!(control->flags & IEEE80211_TXCTL_FIRST_FRAGMENT));

	rt2x00_set_field32(&word, TXD_W0_IFS, desc->ifs);

	rt2x00_set_field32(&word, TXD_W0_DATABYTE_COUNT, length);

	rt2x00_set_field32(&word, TXD_W0_DATABYTE_COUNT, skbdesc->data_len);

	rt2x00_set_field32(&word, TXD_W0_CIPHER, CIPHER_NONE);

	rt2x00_desc_write(txd, 0, word);

}

drivers/net/wireless/rt2x00/rt2x00.h

+1 −3
Original line number Diff line number Diff line
@@ -488,10 +488,8 @@ struct rt2x00lib_ops { 
	 * TX control handlers

	 */

	void (*write_tx_desc) (struct rt2x00_dev *rt2x00dev,

			       __le32 *txd,

			       struct sk_buff *skb,

			       struct txdata_entry_desc *desc,

			       struct ieee80211_hdr *ieee80211hdr,

			       unsigned int length,

			       struct ieee80211_tx_control *control);

	int (*write_tx_data) (struct rt2x00_dev *rt2x00dev,

			      struct data_ring *ring, struct sk_buff *skb,

drivers/net/wireless/rt2x00/rt2x00dev.c

+1 −3
Original line number Diff line number Diff line
@@ -601,7 +601,6 @@ void rt2x00lib_write_tx_desc(struct rt2x00_dev *rt2x00dev, 
	struct txdata_entry_desc desc;

	struct skb_desc *skbdesc = get_skb_desc(skb);

	struct ieee80211_hdr *ieee80211hdr = skbdesc->data;

	__le32 *txd = skbdesc->desc;

	int tx_rate;

	int bitrate;

	int length;
@@ -729,8 +728,7 @@ void rt2x00lib_write_tx_desc(struct rt2x00_dev *rt2x00dev, 
			desc.signal |= 0x08;

	}



	rt2x00dev->ops->lib->write_tx_desc(rt2x00dev, txd, &desc, ieee80211hdr,

					   skbdesc->data_len, control);

	rt2x00dev->ops->lib->write_tx_desc(rt2x00dev, skb, &desc, control);



	/*

	 * Update ring entry.