Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dcda617a authored by John Johansen's avatar John Johansen
Browse files

apparmor: fix refcount bug in profile replacement 



Signed-off-by: default avatarJohn Johansen <john.johansen@canonical.com>
Acked-by: default avatarSeth Arnold <seth.arnold@canonical.com>
parent e1e5fa96

security/apparmor/policy.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -1189,12 +1189,12 @@ ssize_t aa_replace_profiles(void *udata, size_t size, bool noreplace) 
				aa_get_profile(newest);

				aa_get_profile(newest);

				aa_put_profile(parent);

				aa_put_profile(parent);

				rcu_assign_pointer(ent->new->parent, newest);

				rcu_assign_pointer(ent->new->parent, newest);

			} else

			}

				aa_put_profile(newest);

			/* aafs interface uses replacedby */

			/* aafs interface uses replacedby */

			rcu_assign_pointer(ent->new->replacedby->profile,

			rcu_assign_pointer(ent->new->replacedby->profile,

					   aa_get_profile(ent->new));

					   aa_get_profile(ent->new));

			__list_add_profile(&parent->base.profiles, ent->new);

			__list_add_profile(&parent->base.profiles, ent->new);

			aa_put_profile(newest);

		} else {

		} else {

			/* aafs interface uses replacedby */

			/* aafs interface uses replacedby */

			rcu_assign_pointer(ent->new->replacedby->profile,

			rcu_assign_pointer(ent->new->replacedby->profile,