Commit dcd36c43 authored Feb 14, 2017 by Rob Rice Committed by Herbert Xu Feb 15, 2017

crypto: brcm - Avoid double free in ahash_finup()



In Broadcom SPU driver, in case where incremental hash
is done in software in ahash_finup(), tmpbuf was freed
twice.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rob Rice <rob.rice@broadcom.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent eafa2669

drivers/crypto/bcm/cipher.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2331,7 +2331,6 @@ static int ahash_finup(struct ahash_request *req)
		/* Call synchronous update */
		ret = crypto_shash_finup(ctx->shash, tmpbuf, req->nbytes,
		req->result);
		kfree(tmpbuf);
		} else {
		/* Otherwise call the internal function which uses SPU hw */
		return __ahash_finup(req);