Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc99f16f authored by Felipe Balbi's avatar Felipe Balbi
Browse files

usb: dwc3: core: fix ordering for PHY suspend 



We can't suspend the PHYs before dwc3_core_exit_mode()
has been called, that's because the host and/or device
sides might still need to communicate with the far end
link partner.

Fixes: 8ba007a9 (usb: dwc3: core: enable the USB2 and USB3 phy in probe)
Cc: <stable@vger.kernel.org> # v3.9+
Suggested-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent fed33afc

drivers/usb/dwc3/core.c

+5 −4
Original line number Diff line number Diff line
@@ -799,15 +799,16 @@ static int dwc3_remove(struct platform_device *pdev) 
{

	struct dwc3	*dwc = platform_get_drvdata(pdev);



	dwc3_debugfs_exit(dwc);

	dwc3_core_exit_mode(dwc);

	dwc3_event_buffers_cleanup(dwc);

	dwc3_free_event_buffers(dwc);



	usb_phy_set_suspend(dwc->usb2_phy, 1);

	usb_phy_set_suspend(dwc->usb3_phy, 1);

	phy_power_off(dwc->usb2_generic_phy);

	phy_power_off(dwc->usb3_generic_phy);



	dwc3_debugfs_exit(dwc);

	dwc3_core_exit_mode(dwc);

	dwc3_event_buffers_cleanup(dwc);

	dwc3_free_event_buffers(dwc);

	dwc3_core_exit(dwc);



	pm_runtime_put_sync(&pdev->dev);