Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc616b89 authored by Damien Lespiau's avatar Damien Lespiau Committed by Daniel Vetter
Browse files

drm/i915/bdw: The TLB invalidation mechanism has been removed from INSTPM 



While wandering in the spec, I noticed that BDW removes those 2 bits
from INSTPM. I couldn't find any direct way to invalidate the TLB (ie
without the ring working already). Maybe someone will be more lucky.

At least, we now know we may be a problem.

Signed-off-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
Reviewed-by: default avatarBen Widawsky <ben@bwidawsk.net>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 065f2ec2

drivers/gpu/drm/i915/intel_ringbuffer.c

+8 −2
Original line number Diff line number Diff line
@@ -981,8 +981,14 @@ void intel_ring_setup_status_page(struct intel_ring_buffer *ring) 
	I915_WRITE(mmio, (u32)ring->status_page.gfx_addr);

	POSTING_READ(mmio);



	/* Flush the TLB for this page */

	if (INTEL_INFO(dev)->gen >= 6) {

	/*

	 * Flush the TLB for this page

	 *

	 * FIXME: These two bits have disappeared on gen8, so a question

	 * arises: do we still need this and if so how should we go about

	 * invalidating the TLB?

	 */

	if (INTEL_INFO(dev)->gen >= 6 && INTEL_INFO(dev)->gen < 8) {

		u32 reg = RING_INSTPM(ring->mmio_base);



		/* ring should be idle before issuing a sync flush*/