Commit dbfc189c authored Aug 21, 2011 by Julia Lawall Committed by Benjamin Herrenschmidt Nov 25, 2011

powerpc/cell/iommu: Add missing of_node_put

np is initialized to the result of calling a function that calls
of_node_get, so of_node_put should be called before the pointer is dropped.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression e,e1,e2;
@@

* e = \(of_find_node_by_type\|of_find_node_by_name\)(...)
  ... when != of_node_put(e)
      when != true e == NULL
      when != e2 = e
  e = e1
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

parent 8d3d589a

arch/powerpc/platforms/cell/iommu.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1037,6 +1037,8 @@ static int __init cell_iommu_fixed_mapping_init(void)

		/* The fixed mapping is only supported on axon machines */
		np = of_find_node_by_name(NULL, "axon");
		of_node_put(np);

		if (!np) {
		pr_debug("iommu: fixed mapping disabled, no axons found\n");
		return -1;