Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dbf790dc authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Greg Kroah-Hartman
Browse files

can: dev: call netif_carrier_off() in register_candev() 



[ Upstream commit c63845609c4700488e5eacd6ab4d06d5d420e5ef ]

CONFIG_CAN_LEDS is deprecated. When trying to use the generic netdev
trigger as suggested, there's a small inconsistency with the link
property: The LED is on initially, stays on when the device is brought
up, and then turns off (as expected) when the device is brought down.

Make sure the LED always reflects the state of the CAN device.

Signed-off-by: default avatarRasmus Villemoes <rasmus.villemoes@prevas.dk>
Acked-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 43d31fd9

drivers/net/can/dev.c

+2 −0
Original line number Diff line number Diff line
@@ -1260,6 +1260,8 @@ int register_candev(struct net_device *dev) 
		return -EINVAL;



	dev->rtnl_link_ops = &can_link_ops;

	netif_carrier_off(dev);



	return register_netdev(dev);

}

EXPORT_SYMBOL_GPL(register_candev);