Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dbf134f6 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

mtd: rawnand: atmel: Fix potential NULL pointer dereference 



[ Upstream commit fbed20280d912449cfb40c382cb55e3d11502587 ]

There is a potential execution path in which function
of_find_compatible_node() returns NULL. In such a case,
we end up having a NULL pointer dereference when accessing
pointer *nfc_np* in function of_clk_get().

So, we better don't take any chances and fix this by null
checking pointer *nfc_np* before calling of_clk_get().

Addresses-Coverity-ID: 1473052 ("Dereference null return value")
Fixes: f88fc122 ("mtd: nand: Cleanup/rework the atmel_nand driver")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: default avatarBoris Brezillon <boris.brezillon@bootlin.com>
Acked-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ed8aa1c1

drivers/mtd/nand/raw/atmel/nand-controller.c

+4 −0
Original line number Diff line number Diff line
@@ -2063,6 +2063,10 @@ atmel_hsmc_nand_controller_legacy_init(struct atmel_hsmc_nand_controller *nc) 
	nand_np = dev->of_node;

	nfc_np = of_find_compatible_node(dev->of_node, NULL,

					 "atmel,sama5d3-nfc");

	if (!nfc_np) {

		dev_err(dev, "Could not find device node for sama5d3-nfc\n");

		return -ENODEV;

	}



	nc->clk = of_clk_get(nfc_np, 0);

	if (IS_ERR(nc->clk)) {