Commit dbd1ba6a authored Mar 25, 2013 by Santosh Shilimkar Committed by Kevin Hilman Apr 09, 2013

ARM: OMAP4: CPUidle: Avoid double idle driver registration



OMAP4 CPUidle driver registration call is under a loop which leads
to calling cpuidle_register_driver twice which is not intended.

Fix it by moving the driver registration outside the loop.

Reported-by: Nishanth Menon <nm@ti.com>
Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Kevin Hilman <khilman@linaro.org>

parent 0d975589

arch/arm/mach-omap2/cpuidle44xx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -222,14 +222,14 @@ int __init omap4_idle_init(void)
		if (!cpu_clkdm[0] \|\| !cpu_clkdm[1])
		return -ENODEV;

		cpuidle_register_driver(&omap4_idle_driver);

		for_each_cpu(cpu_id, cpu_online_mask) {
		dev = &per_cpu(omap4_idle_dev, cpu_id);
		dev->cpu = cpu_id;
		#ifdef CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED
		dev->coupled_cpus = *cpu_online_mask;
		#endif
		cpuidle_register_driver(&omap4_idle_driver);

		if (cpuidle_register_device(dev)) {
		pr_err("%s: CPUidle register failed\n", __func__);
		return -EIO;