Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dba744cd authored by Lv Zheng's avatar Lv Zheng Committed by Rafael J. Wysocki
Browse files

ACPICA: Dispatcher: Remove unnecessary call to debugger 

ACPICA commit eaa455accf165fee2df26410e271aab162264f6c

UBSAN reports an index out of range use in dsutils.c.
  acpi_db_display_argument_object(
  	walk_state->operands[walk_state->num_operands - 1],
  	                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  	walk_state);

This call was simply wrong, generated redundant debugger messages, and
resulted in a -1 index into the operand stack. Linux kernel bug #120351
(link #1) and #194845 (link #2).

Originally fixed by Navin P.S. (link #1, comment 8), refined by Lv Zheng
(link #3).

Link: https://bugzilla.kernel.org/show_bug.cgi?id=120351 [#1]
Link: https://bugzilla.kernel.org/show_bug.cgi?id=194845 [#2]
Link: https://github.com/acpica/acpica/pull/245          [#3]
Link: https://github.com/acpica/acpica/commit/eaa455ac


Reported-by: default avatarWilfried Klaebe <linux-kernel@lebenslange-mailadresse.de>
Reported-by: default avatarRonald Warsow <rwarsow@gmx.de>
Original-by: default avatarNavin P.S. <navinp1912@gmail.com>
Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 2cb8c3bb

drivers/acpi/acpica/dsutils.c

+0 −9
Original line number Diff line number Diff line
@@ -633,15 +633,6 @@ acpi_ds_create_operand(struct acpi_walk_state *walk_state, 


		if ((op_info->flags & AML_HAS_RETVAL) ||

		    (arg->common.flags & ACPI_PARSEOP_IN_STACK)) {

			ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,

					  "Argument previously created, already stacked\n"));



			acpi_db_display_argument_object(walk_state->

							operands[walk_state->

								 num_operands -

								 1],

							walk_state);



			/*

			 * Use value that was already previously returned

			 * by the evaluation of this argument