Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db9b6040 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Daniel Vetter
Browse files

drm/gma500: remove helper function 



We were getting build warning about:
drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:2: warning: initialization
	from incompatible pointer type

The callback to dpms was pointing to a helper function which had a
return type of void, whereas the callback should point to a function
which has a return type of int.
On closer look it turned out that we do not need the helper function
since if we call drm_helper_connector_dpms() directly, the first check
that drm_helper_connector_dpms() does is: if (mode == connector->dpms)

Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Link: http://patchwork.freedesktop.org/patch/msgid/1454393155-13142-1-git-send-email-sudipm.mukherjee@gmail.com


Acked-by: default avatarPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
parent 1c0230de

drivers/gpu/drm/gma500/mdfld_dsi_output.c

+1 −11
Original line number Diff line number Diff line
@@ -382,16 +382,6 @@ static int mdfld_dsi_connector_mode_valid(struct drm_connector *connector, 
	return MODE_OK;

}



static void mdfld_dsi_connector_dpms(struct drm_connector *connector, int mode)

{

	if (mode == connector->dpms)

		return;



	/*first, execute dpms*/



	drm_helper_connector_dpms(connector, mode);

}



static struct drm_encoder *mdfld_dsi_connector_best_encoder(

				struct drm_connector *connector)

{
@@ -404,7 +394,7 @@ static struct drm_encoder *mdfld_dsi_connector_best_encoder( 


/*DSI connector funcs*/

static const struct drm_connector_funcs mdfld_dsi_connector_funcs = {

	.dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,

	.dpms = drm_helper_connector_dpms,

	.detect = mdfld_dsi_connector_detect,

	.fill_modes = drm_helper_probe_single_connector_modes,

	.set_property = mdfld_dsi_connector_set_property,