Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db9aaa30 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

usb: gadget: rndis: check size of RNDIS_MSG_SET command 



commit 38ea1eac7d88072bbffb630e2b3db83ca649b826 upstream.

Check the size of the RNDIS_MSG_SET command given to us before
attempting to respond to an invalid message size.

Reported-by: default avatarSzymon Heidrich <szymon.heidrich@gmail.com>
Cc: stable@kernel.org
Tested-by: default avatarSzymon Heidrich <szymon.heidrich@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e5eb8d19

drivers/usb/gadget/function/rndis.c

+6 −3
Original line number Diff line number Diff line
@@ -637,14 +637,17 @@ static int rndis_set_response(struct rndis_params *params, 
	rndis_set_cmplt_type *resp;

	rndis_resp_t *r;



	BufLength = le32_to_cpu(buf->InformationBufferLength);

	BufOffset = le32_to_cpu(buf->InformationBufferOffset);

	if ((BufLength > RNDIS_MAX_TOTAL_SIZE) ||

	    (BufOffset + 8 >= RNDIS_MAX_TOTAL_SIZE))

		    return -EINVAL;



	r = rndis_add_response(params, sizeof(rndis_set_cmplt_type));

	if (!r)

		return -ENOMEM;

	resp = (rndis_set_cmplt_type *)r->buf;



	BufLength = le32_to_cpu(buf->InformationBufferLength);

	BufOffset = le32_to_cpu(buf->InformationBufferOffset);



#ifdef	VERBOSE_DEBUG

	pr_debug("%s: Length: %d\n", __func__, BufLength);

	pr_debug("%s: Offset: %d\n", __func__, BufOffset);