Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db918acb authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf evlist: Allow asking for max precise_ip in add_default() 

There are cases where we want to leave attr.precise_ip as zero, such
as when using 'perf record --no-samples', where this would make the
kernel return -EINVAL.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-0u2m2a8rqw781r6m8svqyne8@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 30269dc1

tools/perf/util/evlist.c

+2 −2
Original line number Diff line number Diff line
@@ -242,9 +242,9 @@ void perf_event_attr__set_max_precise_ip(struct perf_event_attr *attr) 
	}

}



int perf_evlist__add_default(struct perf_evlist *evlist)

int __perf_evlist__add_default(struct perf_evlist *evlist, bool precise)

{

	struct perf_evsel *evsel = perf_evsel__new_cycles(true);

	struct perf_evsel *evsel = perf_evsel__new_cycles(precise);



	if (evsel == NULL)

		return -ENOMEM;

tools/perf/util/evlist.h

+8 −1
Original line number Diff line number Diff line
@@ -115,7 +115,14 @@ void perf_evlist__delete(struct perf_evlist *evlist); 


void perf_evlist__add(struct perf_evlist *evlist, struct perf_evsel *entry);

void perf_evlist__remove(struct perf_evlist *evlist, struct perf_evsel *evsel);

int perf_evlist__add_default(struct perf_evlist *evlist);



int __perf_evlist__add_default(struct perf_evlist *evlist, bool precise);



static inline int perf_evlist__add_default(struct perf_evlist *evlist)

{

	return __perf_evlist__add_default(evlist, true);

}



int __perf_evlist__add_default_attrs(struct perf_evlist *evlist,

				     struct perf_event_attr *attrs, size_t nr_attrs);