Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db803f36 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by David S. Miller
Browse files

qed: Fix mask parameter in qed_vf_prep_tunn_req_tlv 

Clang complains when one enumerated type is implicitly converted to
another.

drivers/net/ethernet/qlogic/qed/qed_vf.c:686:6: warning: implicit
conversion from enumeration type 'enum qed_tunn_mode' to different
enumeration type 'enum qed_tunn_clss' [-Wenum-conversion]
                                 QED_MODE_L2GENEVE_TUNN,
                                 ^~~~~~~~~~~~~~~~~~~~~~

Update mask's parameter to expect qed_tunn_mode, which is what was
intended.

Link: https://github.com/ClangBuiltLinux/linux/issues/125


Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a898fba3

drivers/net/ethernet/qlogic/qed/qed_vf.c

+2 −2
Original line number Diff line number Diff line
@@ -572,7 +572,7 @@ int qed_vf_hw_prepare(struct qed_hwfn *p_hwfn) 
static void

__qed_vf_prep_tunn_req_tlv(struct vfpf_update_tunn_param_tlv *p_req,

			   struct qed_tunn_update_type *p_src,

			   enum qed_tunn_clss mask, u8 *p_cls)

			   enum qed_tunn_mode mask, u8 *p_cls)

{

	if (p_src->b_update_mode) {

		p_req->tun_mode_update_mask |= BIT(mask);
@@ -587,7 +587,7 @@ __qed_vf_prep_tunn_req_tlv(struct vfpf_update_tunn_param_tlv *p_req, 
static void

qed_vf_prep_tunn_req_tlv(struct vfpf_update_tunn_param_tlv *p_req,

			 struct qed_tunn_update_type *p_src,

			 enum qed_tunn_clss mask,

			 enum qed_tunn_mode mask,

			 u8 *p_cls, struct qed_tunn_update_udp_port *p_port,

			 u8 *p_update_port, u16 *p_udp_port)

{