Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db737117 authored by Takashi Iwai's avatar Takashi Iwai Committed by Greg Kroah-Hartman
Browse files

ALSA: usx2y: Fix potential NULL dereference 



commit 7686e3485253635c529cdd5f416fc640abaf076f upstream.

The error handling code in usX2Y_rate_set() may hit a potential NULL
dereference when an error occurs before allocating all us->urb[].
Add a proper NULL check for fixing the corner case.

Reported-by: default avatarLin Yi <teroincn@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200420075529.27203-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a6db63ba

sound/usb/usx2y/usbusx2yaudio.c

+2 −0
Original line number Diff line number Diff line
@@ -695,6 +695,8 @@ static int usX2Y_rate_set(struct usX2Ydev *usX2Y, int rate) 
			us->submitted =	2*NOOF_SETRATE_URBS;

			for (i = 0; i < NOOF_SETRATE_URBS; ++i) {

				struct urb *urb = us->urb[i];

				if (!urb)

					continue;

				if (urb->status) {

					if (!err)

						err = -ENODEV;