Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db560d16 authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

selftests: forwarding: mirror_lib: Tighten up VLAN capture 



The function do_test_span_vlan_dir_ips() is used for testing whether
mirrored packets are VLAN-encapsulated. But since it only considers
VLAN encapsulation, it may end up matching unmirrored ARP traffic as
well. One consequence is a rare failure of mirror_gre_vlan_bridge_1q's
test_gretap_untagged_egress. Decreasing ping cadence in mirror_test()
makes the problem easily reproducible.

Therefore tighten up the match criterion to only count those 802.1q
packets where the next header is IP.

Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5025b99c

tools/testing/selftests/net/forwarding/mirror_lib.sh

+1 −1
Original line number Diff line number Diff line
@@ -105,7 +105,7 @@ do_test_span_vlan_dir_ips() 
	# Install the capture as skip_hw to avoid double-counting of packets.

	# The traffic is meant for local box anyway, so will be trapped to

	# kernel.

	vlan_capture_install $dev "skip_hw vlan_id $vid"

	vlan_capture_install $dev "skip_hw vlan_id $vid vlan_ethtype ip"

	mirror_test v$h1 $ip1 $ip2 $dev 100 $expect

	mirror_test v$h2 $ip2 $ip1 $dev 100 $expect

	vlan_capture_uninstall $dev