Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db54e08c authored by Hans de Goede's avatar Hans de Goede Committed by Greg Kroah-Hartman
Browse files

usb: typec: fusb302: Check vconn is off when we start toggling 



[ Upstream commit 32a155b1a83d6659e2272e8e1eec199667b1897e ]

The datasheet says the vconn MUST be off when we start toggling. The
tcpm.c state-machine is responsible to make sure vconn is off, but lets
add a WARN to catch any cases where vconn is not off for some reason.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ce183fad

drivers/usb/typec/fusb302/fusb302.c

+2 −0
Original line number Diff line number Diff line
@@ -641,6 +641,8 @@ static int fusb302_set_toggling(struct fusb302_chip *chip, 
			return ret;

		chip->intr_togdone = false;

	} else {

		/* Datasheet says vconn MUST be off when toggling */

		WARN(chip->vconn_on, "Vconn is on during toggle start");

		/* unmask TOGDONE interrupt */

		ret = fusb302_i2c_clear_bits(chip, FUSB_REG_MASKA,

					     FUSB_REG_MASKA_TOGDONE);