Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db43b8d0 authored by Pan Bian's avatar Pan Bian Committed by Lee Jones
Browse files

mfd: intel_soc_pmic_core: Fix unchecked return value 



unction devm_regmap_init_i2c() returns an ERR_PTR on errors, and its
return value should be checked before it is dereferenced. However, in
function intel_soc_pmic_i2c_probe(), the return value of function
devm_regmap_init_i2c() is used without validation. This patch fixes it.

Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent d1f4f01a

drivers/mfd/intel_soc_pmic_core.c

+3 −0
Original line number Diff line number Diff line
@@ -66,6 +66,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, 
	dev_set_drvdata(dev, pmic);



	pmic->regmap = devm_regmap_init_i2c(i2c, config->regmap_config);

	if (IS_ERR(pmic->regmap))

		return PTR_ERR(pmic->regmap);



	pmic->irq = i2c->irq;



	ret = regmap_add_irq_chip(pmic->regmap, pmic->irq,