Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dae84c8e authored by Thomas Richter's avatar Thomas Richter Committed by David S. Miller
Browse files

s390/qeth: display warning for OSA3 RX/TX checksum offloading 



When RX/TX checksum offloading is turned on and the adapter is
an OSA 3 card in layer 3 mode, the checksum offloading is only
performed when both peers use different adapters. If both peers
share an OSA 3 card, communication is a memory copy and
checksum offloading is not performed.

This patch adds a warning to inform the administrator.

OSA 3 in layer 2 mode does not offer the RX/TX checksum
offload feature.

Signed-off-by: default avatarThomas Richter <tmricht@linux.vnet.ibm.com>
Reviewed-by: default avatarJulian Wiedmann <jwi@linux.vnet.ibm.com>
Reviewed-by: default avatarUrsula Braun <ubraun@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f9d8e6dc

drivers/s390/net/qeth_core_main.c

+5 −0
Original line number Diff line number Diff line
@@ -6116,6 +6116,11 @@ static int qeth_send_checksum_on(struct qeth_card *card, int cstype) 
		if ((required_features & chksum_cb.supported) !=

		    required_features)

			rc = -EIO;

		else if (!(QETH_IPA_CHECKSUM_LP2LP & chksum_cb.supported) &&

			 cstype == IPA_INBOUND_CHECKSUM)

			dev_warn(&card->gdev->dev,

				 "Hardware checksumming is performed only if %s and its peer use different OSA Express 3 ports\n",

				 QETH_CARD_IFNAME(card));

	}

	if (rc) {

		qeth_send_simple_setassparms(card, cstype, IPA_CMD_ASS_STOP, 0);