Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit da88c7f7 authored by Andi Kleen's avatar Andi Kleen Committed by Arnaldo Carvalho de Melo
Browse files

perf stat: Fix --per-core on multi socket systems 



On systems with more than one socket perf stat --per-core would either
segfault or stop before outputting all cores.

The problem was that the output code referenced the id including the
socket number in the higher bits, which is far beyond any per cpu array.

Mask out the socket number before referencing cpus in abs_printout.

I also renamed the variable in nsec_printout to be clear what it is,
even though it doesn't reference cpus.

Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Acked-by: default avatarStephane Eranian <eranian@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1411591846-32736-1-git-send-email-andi@firstfloor.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent cf8102f6

tools/perf/builtin-stat.c

+5 −4
Original line number Diff line number Diff line
@@ -732,7 +732,7 @@ static void aggr_printout(struct perf_evsel *evsel, int id, int nr) 
	}

}



static void nsec_printout(int cpu, int nr, struct perf_evsel *evsel, double avg)

static void nsec_printout(int id, int nr, struct perf_evsel *evsel, double avg)

{

	double msecs = avg / 1e6;

	const char *fmt_v, *fmt_n;
@@ -741,7 +741,7 @@ static void nsec_printout(int cpu, int nr, struct perf_evsel *evsel, double avg) 
	fmt_v = csv_output ? "%.6f%s" : "%18.6f%s";

	fmt_n = csv_output ? "%s" : "%-25s";



	aggr_printout(evsel, cpu, nr);

	aggr_printout(evsel, id, nr);



	scnprintf(name, sizeof(name), "%s%s",

		  perf_evsel__name(evsel), csv_output ? "" : " (msec)");
@@ -947,11 +947,12 @@ static void print_ll_cache_misses(int cpu, 
	fprintf(output, " of all LL-cache hits   ");

}



static void abs_printout(int cpu, int nr, struct perf_evsel *evsel, double avg)

static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)

{

	double total, ratio = 0.0, total2;

	double sc =  evsel->scale;

	const char *fmt;

	int cpu = cpu_map__id_to_cpu(id);



	if (csv_output) {

		fmt = sc != 1.0 ?  "%.2f%s" : "%.0f%s";
@@ -962,7 +963,7 @@ static void abs_printout(int cpu, int nr, struct perf_evsel *evsel, double avg) 
			fmt = sc != 1.0 ? "%18.2f%s" : "%18.0f%s";

	}



	aggr_printout(evsel, cpu, nr);

	aggr_printout(evsel, id, nr);



	if (aggr_mode == AGGR_GLOBAL)

		cpu = 0;