Unverified Commit da13ed1d authored Jul 04, 2018 by Gustavo A. R. Silva Committed by Mark Brown Jul 04, 2018

ASoC: nau8825: use 64-bit arithmetic instead of 32-bit



Add suffix ULL to constant 256 in order to give the compiler complete
information about the proper arithmetic to use.

Notice that such constant is used in a context that expects an
expression of type u64 (64 bits, unsigned) and the following
expression is currently being evaluated using 32-bit arithmetic:

256 * fs * 2 * mclk_src_scaling[i].param

Addresses-Coverity-ID: 1339616 ("Unintentional integer overflow")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent a655de80

sound/soc/codecs/nau8825.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2016,7 +2016,7 @@ static int nau8825_calc_fll_param(unsigned int fll_in, unsigned int fs,
		fvco_max = 0;
		fvco_sel = ARRAY_SIZE(mclk_src_scaling);
		for (i = 0; i < ARRAY_SIZE(mclk_src_scaling); i++) {
		fvco = 256 * fs * 2 * mclk_src_scaling[i].param;
		fvco = 256ULL * fs * 2 * mclk_src_scaling[i].param;
		if (fvco > NAU_FVCO_MIN && fvco < NAU_FVCO_MAX &&
		fvco_max < fvco) {
		fvco_max = fvco;