Commit d9a5f210 authored Jul 19, 2010 by Shreyas Bhatewara Committed by David S. Miller Jul 19, 2010

net-next: vmxnet3 fixes [4/5] Do not reset when the device is not opened



Hold rtnl_lock to get the right link state.

While asynchronously resetting the device, hold rtnl_lock to get the
right value from netif_running. If a reset is scheduled, and the device
goes thru close and open, it may happen that reset and open may run in
parallel. Holding rtnl_lock will avoid this.

Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent bd27290a

drivers/net/vmxnet3/vmxnet3_drv.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2365,6 +2365,7 @@ vmxnet3_reset_work(struct work_struct *data)
		return;

		/* if the device is closed, we must leave it alone */
		rtnl_lock();
		if (netif_running(adapter->netdev)) {
		printk(KERN_INFO "%s: resetting\n", adapter->netdev->name);
		vmxnet3_quiesce_dev(adapter);
		@@ -2373,6 +2374,7 @@ vmxnet3_reset_work(struct work_struct *data)
		} else {
		printk(KERN_INFO "%s: already closed\n", adapter->netdev->name);
		}
		rtnl_unlock();

		clear_bit(VMXNET3_STATE_BIT_RESETTING, &adapter->state);
		}