Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d97a1b56 authored by Linus Walleij's avatar Linus Walleij
Browse files

gpio: dwapb: fix bgpio usage 



The DW APB GPIO driver uses the generic GPIO library gpio-mmio,
and initialize the flags as "false", which should be 0.

When no flags are given, the native endianness is used to access
the MMIO registers, and the pin2mask() call can simply be
converted to a BIT() call, as per the default pin2mask()
implementation in gpio-mmio.c.

Acked-by: default avatarAlan Tull <atull@kernel.org>
Acked-by: default avatarHoan Tran <hotran@apm.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent dbe776c2

drivers/gpio/gpio-dwapb.c

+2 −2
Original line number Diff line number Diff line
@@ -320,7 +320,7 @@ static int dwapb_gpio_set_debounce(struct gpio_chip *gc, 
	struct dwapb_gpio_port *port = gpiochip_get_data(gc);

	struct dwapb_gpio *gpio = port->gpio;

	unsigned long flags, val_deb;

	unsigned long mask = gc->pin2mask(gc, offset);

	unsigned long mask = BIT(offset);



	spin_lock_irqsave(&gc->bgpio_lock, flags);
@@ -482,7 +482,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, 
		(pp->idx * GPIO_SWPORT_DDR_SIZE);



	err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout,

			 NULL, false);

			 NULL, 0);

	if (err) {

		dev_err(gpio->dev, "failed to init gpio chip for port%d\n",

			port->idx);