Commit d9246240 authored Oct 02, 2012 by Hans Verkuil Committed by Mauro Carvalho Chehab Oct 07, 2012

[media] v4l2-ioctl: fix W=1 warnings



Since the prt_names() macro is always called with an unsigned index the
((a) >= 0) condition is always true and gives a compiler warning when
compiling with W=1.
Rewrite the macro to avoid that warning, but cast the index to unsigned
just in case it is ever called with a signed argument.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 1b8b10cc

drivers/media/v4l2-core/v4l2-ioctl.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -157,8 +157,7 @@ static const char *v4l2_memory_names[] = {
		[V4L2_MEMORY_OVERLAY] = "overlay",
		};

		#define prt_names(a, arr) ((((a) >= 0) && ((a) < ARRAY_SIZE(arr))) ? \
		arr[a] : "unknown")
		#define prt_names(a, arr) (((unsigned)(a)) < ARRAY_SIZE(arr) ? arr[a] : "unknown")

		/* ------------------------------------------------------------------ */
		/* debug help functions */