Commit d8a89c3e authored Feb 04, 2019 by Chris Coulson Committed by Greg Kroah-Hartman Dec 05, 2019

apparmor: delete the dentry in aafs_remove() to avoid a leak



[ Upstream commit 201218e4d3dfa1346e30997f48725acce3f26d01 ]

Although the apparmorfs dentries are always dropped from the dentry cache
when the usage count drops to zero, there is no guarantee that this will
happen in aafs_remove(), as another thread might still be using it. In
this scenario, this means that the dentry will temporarily continue to
appear in the results of lookups, even after the call to aafs_remove().

In the case of removal of a profile - it also causes simple_rmdir()
on the profile directory to fail, as the directory won't be empty until
the usage counts of all child dentries have decreased to zero. This
results in the dentry for the profile directory leaking and appearing
empty in the file system tree forever.

Signed-off-by: Chris Coulson <chris.coulson@canonical.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent aa1844c9

security/apparmor/apparmorfs.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -361,6 +361,7 @@ static void aafs_remove(struct dentry *dentry)
		simple_rmdir(dir, dentry);
		else
		simple_unlink(dir, dentry);
		d_delete(dentry);
		dput(dentry);
		}
		inode_unlock(dir);