Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d88d9321 authored by Pawel Harlozinski's avatar Pawel Harlozinski Committed by Greg Kroah-Hartman
Browse files

ASoC: Jack: Fix NULL pointer dereference in snd_soc_jack_report 



commit 8f157d4ff039e03e2ed4cb602eeed2fd4687a58f upstream.

Check for existance of jack before tracing.
NULL pointer dereference has been reported by KASAN while unloading
machine driver (snd_soc_cnl_rt274).

Signed-off-by: default avatarPawel Harlozinski <pawel.harlozinski@linux.intel.com>
Link: https://lore.kernel.org/r/20191112130237.10141-1-pawel.harlozinski@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 29674d00

sound/soc/soc-jack.c

+1 −2
Original line number Diff line number Diff line
@@ -100,10 +100,9 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask) 
	unsigned int sync = 0;

	int enable;



	trace_snd_soc_jack_report(jack, mask, status);



	if (!jack)

		return;

	trace_snd_soc_jack_report(jack, mask, status);



	dapm = &jack->card->dapm;