Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d86a83f4 authored by Tobias Klauser's avatar Tobias Klauser Committed by Greg Kroah-Hartman
Browse files

USB: gadget: imx_udc: Use resource size 



Use the resource_size function instead of manually calculating the
resource size. This reduces the chance of introducing off-by-one errors.

Signed-off-by: default avatarTobias Klauser <tklauser@distanz.ch>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 2f13612a

drivers/usb/gadget/imx_udc.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -1402,7 +1402,8 @@ static int __init imx_udc_probe(struct platform_device *pdev) 
	struct clk *clk;

	struct clk *clk;

	void __iomem *base;

	void __iomem *base;

	int ret = 0;

	int ret = 0;

	int i, res_size;

	int i;

	resource_size_t res_size;





	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!res) {

	if (!res) {
@@ -1416,7 +1417,7 @@ static int __init imx_udc_probe(struct platform_device *pdev) 
		return -ENODEV;

		return -ENODEV;

	}

	}





	res_size = res->end - res->start + 1;

	res_size = resource_size(res);

	if (!request_mem_region(res->start, res_size, res->name)) {

	if (!request_mem_region(res->start, res_size, res->name)) {

		dev_err(&pdev->dev, "can't allocate %d bytes at %d address\n",

		dev_err(&pdev->dev, "can't allocate %d bytes at %d address\n",

			res_size, res->start);

			res_size, res->start);
@@ -1527,8 +1528,7 @@ static int __exit imx_udc_remove(struct platform_device *pdev) 
	clk_disable(imx_usb->clk);

	clk_disable(imx_usb->clk);

	iounmap(imx_usb->base);

	iounmap(imx_usb->base);





	release_mem_region(imx_usb->res->start,

	release_mem_region(imx_usb->res->start, resource_size(imx_usb->res));

		imx_usb->res->end - imx_usb->res->start + 1);





	if (pdata->exit)

	if (pdata->exit)

		pdata->exit(&pdev->dev);

		pdata->exit(&pdev->dev);