Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8004cb9 authored by Larry Finger's avatar Larry Finger Committed by John W. Linville
Browse files

b43legacy: Fix sparse warnings 



Sparse yields the following warnings for b43legacy:

  CHECK   drivers/net/wireless/b43legacy/phy.c
drivers/net/wireless/b43legacy/phy.c:1304:31: warning: potentially expensive pointer subtraction
drivers/net/wireless/b43legacy/phy.c:1304:31: warning: potentially expensive pointer subtraction
drivers/net/wireless/b43legacy/phy.c:1304:31: warning: potentially expensive pointer subtraction
  CHECK   drivers/net/wireless/b43legacy/debugfs.c
drivers/net/wireless/b43legacy/debugfs.c:243:9: warning: memset with byte count of 131072

Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent c1db52b9

drivers/net/wireless/b43legacy/debugfs.c

+1 −1
Original line number Diff line number Diff line
@@ -211,7 +211,7 @@ static ssize_t b43legacy_debugfs_read(struct file *file, char __user *userbuf, 
	struct b43legacy_dfs_file *dfile;

	ssize_t uninitialized_var(ret);

	char *buf;

	const size_t bufsize = 1024 * 128;

	const size_t bufsize = 1024 * 16; /* 16 KiB buffer */

	const size_t buforder = get_order(bufsize);

	int err = 0;

drivers/net/wireless/b43legacy/phy.c

+2 −4
Original line number Diff line number Diff line
@@ -1296,12 +1296,10 @@ void b43legacy_lo_write(struct b43legacy_wldev *dev, 
	/* Sanity check. */

	if (pair->low < -8 || pair->low > 8 ||

	    pair->high < -8 || pair->high > 8) {

		struct b43legacy_phy *phy = &dev->phy;

		b43legacydbg(dev->wl,

		       "WARNING: Writing invalid LOpair "

		       "(low: %d, high: %d, index: %lu)\n",

		       pair->low, pair->high,

		       (unsigned long)(pair - phy->_lo_pairs));

		       "(low: %d, high: %d)\n",

		       pair->low, pair->high);

		dump_stack();

	}

#endif