Commit d7ed5fc0 authored Jun 24, 2020 by Mathias Nyman Committed by Sasha Levin Jun 30, 2020

xhci: Fix incorrect EP_STATE_MASK



commit dceea67058fe22075db3aed62d5cb62092be5053 upstream.

EP_STATE_MASK should be 0x7 instead of 0xf

xhci spec 6.2.3 shows that the EP state field in the endpoint context data
structure consist of bits [2:0].
The old value included a bit from the next field which fortunately is a
 RsvdZ region. So hopefully this hasn't caused too much harm

Cc: stable@vger.kernel.org
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20200624135949.22611-2-mathias.nyman@linux.intel.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d2621f15

drivers/usb/host/xhci.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -716,7 +716,7 @@ struct xhci_ep_ctx {
		* 4 - TRB error
		* 5-7 - reserved
		*/
		#define EP_STATE_MASK (0xf)
		#define EP_STATE_MASK (0x7)
		#define EP_STATE_DISABLED 0
		#define EP_STATE_RUNNING 1
		#define EP_STATE_HALTED 2