Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d759f906 authored by David Howells's avatar David Howells
Browse files

Annotate hardware config module parameters in drivers/gpio/ 



When the kernel is running in secure boot mode, we lock down the kernel to
prevent userspace from modifying the running kernel image.  Whilst this
includes prohibiting access to things like /dev/mem, it must also prevent
access by means of configuring driver modules in such a way as to cause a
device to access or modify the kernel image.

To this end, annotate module_param* statements that refer to hardware
configuration and indicate for future reference what type of parameter they
specify.  The parameter parser in the core sees this information and can
skip such parameters with an error message if the kernel is locked down.
The module initialisation then runs as normal, but just sees whatever the
default values for those parameters is.

Note that we do still need to do the module initialisation because some
drivers have viable defaults set in case parameters aren't specified and
some drivers support automatic configuration (e.g. PNP or PCI) in addition
to manually coded parameters.

This patch annotates drivers in drivers/gpio/.

Suggested-by: default avatarAlan Cox <gnomes@lxorguk.ukuu.org.uk>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Acked-by: default avatarWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
cc: Alexandre Courbot <gnurou@gmail.com>
cc: linux-gpio@vger.kernel.org
parent 40059ec6

drivers/gpio/gpio-104-dio-48e.c

+2 −2
Original line number Diff line number Diff line
@@ -33,11 +33,11 @@ 


static unsigned int base[MAX_NUM_DIO48E];

static unsigned int num_dio48e;

module_param_array(base, uint, &num_dio48e, 0);

module_param_hw_array(base, uint, ioport, &num_dio48e, 0);

MODULE_PARM_DESC(base, "ACCES 104-DIO-48E base addresses");



static unsigned int irq[MAX_NUM_DIO48E];

module_param_array(irq, uint, NULL, 0);

module_param_hw_array(irq, uint, irq, NULL, 0);

MODULE_PARM_DESC(irq, "ACCES 104-DIO-48E interrupt line numbers");



/**

drivers/gpio/gpio-104-idi-48.c

+2 −2
Original line number Diff line number Diff line
@@ -33,11 +33,11 @@ 


static unsigned int base[MAX_NUM_IDI_48];

static unsigned int num_idi_48;

module_param_array(base, uint, &num_idi_48, 0);

module_param_hw_array(base, uint, ioport, &num_idi_48, 0);

MODULE_PARM_DESC(base, "ACCES 104-IDI-48 base addresses");



static unsigned int irq[MAX_NUM_IDI_48];

module_param_array(irq, uint, NULL, 0);

module_param_hw_array(irq, uint, irq, NULL, 0);

MODULE_PARM_DESC(irq, "ACCES 104-IDI-48 interrupt line numbers");



/**

drivers/gpio/gpio-104-idio-16.c

+2 −2
Original line number Diff line number Diff line
@@ -33,11 +33,11 @@ 


static unsigned int base[MAX_NUM_IDIO_16];

static unsigned int num_idio_16;

module_param_array(base, uint, &num_idio_16, 0);

module_param_hw_array(base, uint, ioport, &num_idio_16, 0);

MODULE_PARM_DESC(base, "ACCES 104-IDIO-16 base addresses");



static unsigned int irq[MAX_NUM_IDIO_16];

module_param_array(irq, uint, NULL, 0);

module_param_hw_array(irq, uint, irq, NULL, 0);

MODULE_PARM_DESC(irq, "ACCES 104-IDIO-16 interrupt line numbers");



/**

drivers/gpio/gpio-gpio-mm.c

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ 


static unsigned int base[MAX_NUM_GPIOMM];

static unsigned int num_gpiomm;

module_param_array(base, uint, &num_gpiomm, 0);

module_param_hw_array(base, uint, ioport, &num_gpiomm, 0);

MODULE_PARM_DESC(base, "Diamond Systems GPIO-MM base addresses");



/**

drivers/gpio/gpio-ws16c48.c

+2 −2
Original line number Diff line number Diff line
@@ -30,11 +30,11 @@ 


static unsigned int base[MAX_NUM_WS16C48];

static unsigned int num_ws16c48;

module_param_array(base, uint, &num_ws16c48, 0);

module_param_hw_array(base, uint, ioport, &num_ws16c48, 0);

MODULE_PARM_DESC(base, "WinSystems WS16C48 base addresses");



static unsigned int irq[MAX_NUM_WS16C48];

module_param_array(irq, uint, NULL, 0);

module_param_hw_array(irq, uint, irq, NULL, 0);

MODULE_PARM_DESC(irq, "WinSystems WS16C48 interrupt line numbers");



/**