Commit d725fdc8 authored Aug 10, 2007 by Oleg Nesterov Committed by David S. Miller Aug 13, 2007

[DCCP]: fix theoretical ccids_{read,write}_lock() race



Make sure that spin_unlock_wait() is properly ordered wrt atomic_inc().

(akpm: can't we convert this code to use rwlocks?)

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b5890d8b

net/dccp/ccid.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -40,6 +40,7 @@ static inline void ccids_write_unlock(void)
		static inline void ccids_read_lock(void)
		{
		atomic_inc(&ccids_lockct);
		smp_mb__after_atomic_inc();
		spin_unlock_wait(&ccids_lock);
		}