Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d70eaa38 authored by Vadim Pasternak's avatar Vadim Pasternak Committed by David S. Miller
Browse files

mlxsw: i2c: Fix buffer increment counter for write transaction 



It fixes a problem for the last chunk where 'chunk_size' is smaller than
MLXSW_I2C_BLK_MAX and data is copied to the wrong offset, overriding
previous data.

Fixes: 6882b0ae ("mlxsw: Introduce support for I2C bus")
Signed-off-by: default avatarVadim Pasternak <vadimp@mellanox.com>
Reviewed-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 122f00cd

drivers/net/ethernet/mellanox/mlxsw/i2c.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -294,7 +294,7 @@ mlxsw_i2c_write(struct device *dev, size_t in_mbox_size, u8 *in_mbox, int num, 
		write_tran.len = MLXSW_I2C_ADDR_WIDTH + chunk_size;

		write_tran.len = MLXSW_I2C_ADDR_WIDTH + chunk_size;

		mlxsw_i2c_set_slave_addr(tran_buf, off);

		mlxsw_i2c_set_slave_addr(tran_buf, off);

		memcpy(&tran_buf[MLXSW_I2C_ADDR_BUF_SIZE], in_mbox +

		memcpy(&tran_buf[MLXSW_I2C_ADDR_BUF_SIZE], in_mbox +

		       chunk_size * i, chunk_size);

		       MLXSW_I2C_BLK_MAX * i, chunk_size);





		j = 0;

		j = 0;

		end = jiffies + timeout;

		end = jiffies + timeout;