Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6d76e02 authored by Fan Guo's avatar Fan Guo Committed by Sasha Levin
Browse files

RDMA/mad: Fix possible memory leak in ib_mad_post_receive_mads() 

[ Upstream commit a17f4bed811c60712d8131883cdba11a105d0161 ]

If ib_dma_mapping_error() returns non-zero value,
ib_mad_post_receive_mads() will jump out of loops and return -ENOMEM
without freeing mad_priv. Fix this memory-leak problem by freeing mad_priv
in this case.

Fixes: 2c34e68f ("IB/mad: Check and handle potential DMA mapping errors")
Link: https://lore.kernel.org/r/20200612063824.180611-1-guofan5@huawei.com


Signed-off-by: default avatarFan Guo <guofan5@huawei.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent df588891

drivers/infiniband/core/mad.c

+1 −0
Original line number Diff line number Diff line
@@ -2920,6 +2920,7 @@ static int ib_mad_post_receive_mads(struct ib_mad_qp_info *qp_info, 
						 DMA_FROM_DEVICE);

		if (unlikely(ib_dma_mapping_error(qp_info->port_priv->device,

						  sg_list.addr))) {

			kfree(mad_priv);

			ret = -ENOMEM;

			break;

		}