Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6c4dc3b authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by Johan Hovold
Browse files

USB: serial: cp210x: use kmemdup 



Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.

Signed-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent d8d841e8

drivers/usb/serial/cp210x.c

+1 −3
Original line number Diff line number Diff line
@@ -496,12 +496,10 @@ static int cp210x_write_reg_block(struct usb_serial_port *port, u8 req, 
	void *dmabuf;

	int result;



	dmabuf = kmalloc(bufsize, GFP_KERNEL);

	dmabuf = kmemdup(buf, bufsize, GFP_KERNEL);

	if (!dmabuf)

		return -ENOMEM;



	memcpy(dmabuf, buf, bufsize);



	result = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),

			req, REQTYPE_HOST_TO_INTERFACE, 0,

			port_priv->bInterfaceNumber, dmabuf, bufsize,