Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6926078 authored by Venkata Manasa Kakarla's avatar Venkata Manasa Kakarla
Browse files

serial: msm_geni_serial: Don't use WARN_ON for console uart



In handler_isr for console uart cases using warn_on for debugging
issues will further lead into the spinlock recursion where the
interrupt routine holds the spinlock and will try to print log
which again needs to acquire the spinlock.
To resolve this recursion issue replaced the warn_on with IPC logs
for console uart.

Change-Id: I6a0a10ff8c14a8ad6c74652f6d4e6e66ffcee13b
Signed-off-by: default avatarvenkata manasa kakarla <venkka@codeaurora.org>
parent e11d06a5
Loading
Loading
Loading
Loading
+6 −1
Original line number Diff line number Diff line
@@ -1815,6 +1815,11 @@ static void msm_geni_serial_handle_isr(struct uart_port *uport,
						SE_GENI_S_IRQ_CLEAR);
	m_irq_en = geni_read_reg_nolog(uport->membase, SE_GENI_M_IRQ_EN);
	if ((m_irq_status & M_ILLEGAL_CMD_EN)) {
		if (uart_console(uport))
			IPC_LOG_MSG(msm_port->console_log,
				"%s.Illegal interrupt. sirq 0x%x mirq:0x%x\n",
				 __func__, s_irq_status, m_irq_status);
		else
			WARN_ON(1);
		goto exit_geni_serial_isr;
	}