Commit d65b7d33 authored Nov 06, 2018 by Vasily Averin Committed by Greg Kroah-Hartman Nov 21, 2018

ext4: avoid buffer leak on shutdown in ext4_mark_iloc_dirty()



commit a6758309a005060b8297a538a457c88699cb2520 upstream.

ext4_mark_iloc_dirty() callers expect that it releases iloc->bh
even if it returns an error.

Fixes: 0db1ff22 ("ext4: add shutdown bit and check for it")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 4.11
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 36b1ba6a

fs/ext4/inode.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -5804,9 +5804,10 @@ int ext4_mark_iloc_dirty(handle_t *handle,
		{
		int err = 0;

		if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb))))
		if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) {
		put_bh(iloc->bh);
		return -EIO;

		}
		if (IS_I_VERSION(inode))
		inode_inc_iversion(inode);