Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d63d07c6 authored by Liam Breck's avatar Liam Breck Committed by Sebastian Reichel
Browse files

power: supply: bq24190_charger: Limit over/under voltage fault logging 



If the charger is unplugged before the battery is full we may
see an over/under voltage fault. Ignore this rather then emitting
a message or uevent.

This fixes messages like these getting logged on charger unplug + replug:
bq24190-charger 15-006b: Fault: boost 0, charge 1, battery 0, ntc 0
bq24190-charger 15-006b: Fault: boost 0, charge 0, battery 0, ntc 0

Cc: Tony Lindgren <tony@atomide.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarLiam Breck <kernel@networkimprov.net>
Acked-by: default avatarTony Lindgren <tony@atomide.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent 53db8858

drivers/power/supply/bq24190_charger.c

+6 −1
Original line number Diff line number Diff line
@@ -1222,8 +1222,13 @@ static void bq24190_check_status(struct bq24190_dev_info *bdi) 
		}

	} while (f_reg && ++i < 2);



	/* ignore over/under voltage fault after disconnect */

	if (f_reg == (1 << BQ24190_REG_F_CHRG_FAULT_SHIFT) &&

	    !(ss_reg & BQ24190_REG_SS_PG_STAT_MASK))

		f_reg = 0;



	if (f_reg != bdi->f_reg) {

		dev_info(bdi->dev,

		dev_warn(bdi->dev,

			"Fault: boost %d, charge %d, battery %d, ntc %d\n",

			!!(f_reg & BQ24190_REG_F_BOOST_FAULT_MASK),

			!!(f_reg & BQ24190_REG_F_CHRG_FAULT_MASK),