Commit d618bf2b authored Sep 24, 2015 by Russell King Committed by David S. Miller Sep 24, 2015

phy: fixed-phy: properly validate phy in fixed_phy_update_state()



Validate that the phy_device passed into fixed_phy_update_state() is a
fixed-phy device before walking the list of phys for a fixed phy at the
same address.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 04d53b20

drivers/net/phy/fixed_phy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -220,7 +220,7 @@ int fixed_phy_update_state(struct phy_device *phydev,
		struct fixed_mdio_bus *fmb = &platform_fmb;
		struct fixed_phy *fp;

		if (!phydev \|\| !phydev->bus)
		if (!phydev \|\| phydev->bus != fmb->mii_bus)
		return -EINVAL;

		list_for_each_entry(fp, &fmb->phys, node) {