Commit d5e0d0f6 authored Apr 07, 2013 by Mathias Krause Committed by David S. Miller Apr 07, 2013

VSOCK: Fix missing msg_namelen update in vsock_stream_recvmsg()

The code misses to update the msg_namelen member to 0 and therefore
makes net/socket.c leak the local, uninitialized sockaddr_storage
variable to userland -- 128 bytes of kernel stack memory.

Cc: Andy King <acking@vmware.com>
Cc: Dmitry Torokhov <dtor@vmware.com>
Cc: George Zhang <georgezhang@vmware.com>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 680d04e0

net/vmw_vsock/af_vsock.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1670,6 +1670,8 @@ vsock_stream_recvmsg(struct kiocb *kiocb,
		vsk = vsock_sk(sk);
		err = 0;

		msg->msg_namelen = 0;

		lock_sock(sk);

		if (sk->sk_state != SS_CONNECTED) {