Commit d5b42e66 authored Dec 13, 2017 by Wolfgang Grandegger Committed by Marc Kleine-Budde Jan 04, 2018

can: gs_usb: fix return value of the "set_bittiming" callback



The "set_bittiming" callback treats a positive return value as error!
For that reason "can_changelink()" will quit silently after setting
the bittiming values without processing ctrlmode, restart-ms, etc.

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent b4c2951a

drivers/net/can/usb/gs_usb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -449,7 +449,7 @@ static int gs_usb_set_bittiming(struct net_device *netdev)
		dev_err(netdev->dev.parent, "Couldn't set bittimings (err=%d)",
		rc);

		return rc;
		return (rc > 0) ? 0 : rc;
		}

		static void gs_usb_xmit_callback(struct urb *urb)