Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5400aab authored by Leo (Sunpeng) Li's avatar Leo (Sunpeng) Li Committed by Alex Deucher
Browse files

drm/amd/display: Use correct error codes 



Should return -ENOMEM when allocation fails.
Also, just return the error code instead of using a variable.

Signed-off-by: default avatarLeo (Sunpeng) Li <sunpeng.li@amd.com>
Reviewed-by: default avatarHarry Wentland <Harry.Wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 8c45c5db

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+3 −6
Original line number Original line Diff line number Diff line
@@ -4761,10 +4761,8 @@ static int dm_update_planes_state(struct dc *dc, 
			WARN_ON(dm_new_plane_state->dc_state);

			WARN_ON(dm_new_plane_state->dc_state);





			dc_new_plane_state = dc_create_plane_state(dc);

			dc_new_plane_state = dc_create_plane_state(dc);

			if (!dc_new_plane_state) {

			if (!dc_new_plane_state)

				ret = -EINVAL;

				return -ENOMEM;

				return ret;

			}





			DRM_DEBUG_DRIVER("Enabling DRM plane: %d on DRM crtc %d\n",

			DRM_DEBUG_DRIVER("Enabling DRM plane: %d on DRM crtc %d\n",

					plane->base.id, new_plane_crtc->base.id);

					plane->base.id, new_plane_crtc->base.id);
@@ -4793,8 +4791,7 @@ static int dm_update_planes_state(struct dc *dc, 
					dm_state->context)) {

					dm_state->context)) {





				dc_plane_state_release(dc_new_plane_state);

				dc_plane_state_release(dc_new_plane_state);

				ret = -EINVAL;

				return -EINVAL;

				return ret;

			}

			}





			dm_new_plane_state->dc_state = dc_new_plane_state;

			dm_new_plane_state->dc_state = dc_new_plane_state;