Commit d52eaea9 authored Apr 21, 2023 by Ekaterina Orlova Committed by Greg Kroah-Hartman Apr 26, 2023

ASN.1: Fix check for strdup() success



commit 5a43001c01691dcbd396541e6faa2c0077378f48 upstream.

It seems there is a misprint in the check of strdup() return code that
can lead to NULL pointer dereference.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 4520c6a4 ("X.509: Add simple ASN.1 grammar compiler")
Signed-off-by: Ekaterina Orlova <vorobushek.ok@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: keyrings@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org
Link: https://lore.kernel.org/r/20230315172130.140-1-vorobushek.ok@gmail.com/


Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 0915a439

scripts/asn1_compiler.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -629,7 +629,7 @@ int main(int argc, char **argv)
		p = strrchr(argv[1], '/');
		p = p ? p + 1 : argv[1];
		grammar_name = strdup(p);
		if (!p) {
		if (!grammar_name) {
		perror(NULL);
		exit(1);
		}