Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d4cfa4d1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai
Browse files

OSS: soundcard: locking bug in sound_ioctl() 



We shouldn't return directly here because we're still holding the
&soundcard_mutex.

This bug goes all the way back to the start of git.  It's strange that
no one has complained about it as a runtime bug.

CC: stable@kernel.org
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent cb655d0f

sound/oss/soundcard.c

+2 −2
Original line number Diff line number Diff line
@@ -391,11 +391,11 @@ static long sound_ioctl(struct file *file, unsigned int cmd, unsigned long arg) 
	case SND_DEV_DSP:

	case SND_DEV_DSP16:

	case SND_DEV_AUDIO:

		return audio_ioctl(dev, file, cmd, p);

		ret = audio_ioctl(dev, file, cmd, p);

		break;



	case SND_DEV_MIDIN:

		return MIDIbuf_ioctl(dev, file, cmd, p);

		ret = MIDIbuf_ioctl(dev, file, cmd, p);

		break;



	}