Commit d48ad080 authored Jun 07, 2017 by Jason A. Donenfeld Committed by Theodore Ts'o Jun 19, 2017

rhashtable: use get_random_u32 for hash_rnd

This is much faster and just as secure. It also has the added benefit of
probably returning better randomness at early-boot on systems with
architectural RNGs.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Thomas Graf <tgraf@suug.ch>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent ae5b806a

lib/rhashtable.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -235,7 +235,7 @@ static struct bucket_table bucket_table_alloc(struct rhashtable ht,

	INIT_LIST_HEAD(&tbl->walkers);		INIT_LIST_HEAD(&tbl->walkers);

	get_random_bytes(&tbl->hash_rnd, sizeof(tbl->hash_rnd));		tbl->hash_rnd = get_random_u32();

	for (i = 0; i < nbuckets; i++)		for (i = 0; i < nbuckets; i++)
	INIT_RHT_NULLS_HEAD(tbl->buckets[i], ht, i);		INIT_RHT_NULLS_HEAD(tbl->buckets[i], ht, i);