Commit d4238aa4 authored Sep 20, 2017 by Andrew Jeffery Committed by Wim Van Sebroeck Dec 28, 2017

watchdog: aspeed: Move init to arch_initcall



Probing at device_initcall time lead to perverse cases where the
watchdog was probed after, say, I2C devices, which then leaves a
potentially running watchdog at the mercy of I2C device behaviour and
bus conditions.

Load the watchdog driver early to ensure that the kernel is patting it
well before initialising peripherals.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>

parent 2050dd06

drivers/watchdog/aspeed_wdt.c

+12 −1

Original line number	Diff line number	Diff line
		@@ -316,7 +316,18 @@ static struct platform_driver aspeed_watchdog_driver = {
		.of_match_table = of_match_ptr(aspeed_wdt_of_table),
		},
		};
		module_platform_driver(aspeed_watchdog_driver);

		static int __init aspeed_wdt_init(void)
		{
		return platform_driver_register(&aspeed_watchdog_driver);
		}
		arch_initcall(aspeed_wdt_init);

		static void __exit aspeed_wdt_exit(void)
		{
		platform_driver_unregister(&aspeed_watchdog_driver);
		}
		module_exit(aspeed_wdt_exit);

		MODULE_DESCRIPTION("Aspeed Watchdog Driver");
		MODULE_LICENSE("GPL");