Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3fbd457 authored by Mark Brown's avatar Mark Brown
Browse files

spi: Use bitfields for multiple data lines



Trent Piepho observed that since the current realistic maximum number of
data lines is four we can pack the spi_transfer struct more efficiently
if we use a bitfield for the number of bits, allowing the fields to fit
in a single byte along with cs_change.

If space becomes an issue further optimiation is possible by only using
the constants and packing the values chosen for them.

Reported-by: default avatarTrent Piepho <tpiepho@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent a89e2d27
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -576,8 +576,8 @@ struct spi_transfer {
	dma_addr_t	rx_dma;

	unsigned	cs_change:1;
	u8		tx_nbits;
	u8		rx_nbits;
	unsigned	tx_nbits:3;
	unsigned	rx_nbits:3;
#define	SPI_NBITS_SINGLE	0x01 /* 1bit transfer */
#define	SPI_NBITS_DUAL		0x02 /* 2bits transfer */
#define	SPI_NBITS_QUAD		0x04 /* 4bits transfer */