Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3bcb757 authored by Chris Wilson's avatar Chris Wilson Committed by Keith Packard
Browse files

drm/i915/crt: Explicitly return false if connected to a digital monitor 



Rather than proceed on and silently return false by default, mention why
we rejected the presence of an EDID as implying the presence of a VGA
monitor. (The question arises whether there is a broken EDID which falsely
reports a digital connection when attached by VGA.)

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarKeith Packard <keithp@keithp.com>
Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
parent 9f405100

drivers/gpu/drm/i915/intel_crt.c

+4 −0
Original line number Diff line number Diff line
@@ -288,6 +288,8 @@ static bool intel_crt_detect_ddc(struct drm_connector *connector) 
		 * This may be a DVI-I connector with a shared DDC

		 * link between analog and digital outputs, so we

		 * have to check the EDID input spec of the attached device.

		 *

		 * On the other hand, what should we do if it is a broken EDID?

		 */

		if (edid != NULL) {

			is_digital = edid->input & DRM_EDID_INPUT_DIGITAL;
@@ -298,6 +300,8 @@ static bool intel_crt_detect_ddc(struct drm_connector *connector) 
		if (!is_digital) {

			DRM_DEBUG_KMS("CRT detected via DDC:0x50 [EDID]\n");

			return true;

		} else {

			DRM_DEBUG_KMS("CRT not detected via DDC:0x50 [EDID reports a digital panel]\n");

		}

	}