Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3988079 authored by Kangjie Lu's avatar Kangjie Lu Committed by Greg Kroah-Hartman
Browse files

netfilter: nf_tables: fix a missing check of nla_put_failure 



[ Upstream commit eb8950861c1bfd3eecc8f6faad213e3bca0dc395 ]

If nla_nest_start() may fail. The fix checks its return value and goes
to nla_put_failure if it fails.

Signed-off-by: default avatarKangjie Lu <kjlu@umn.edu>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a787b7ac

net/netfilter/nf_tables_api.c

+2 −0
Original line number Diff line number Diff line
@@ -5737,6 +5737,8 @@ static int nf_tables_fill_flowtable_info(struct sk_buff *skb, struct net *net, 
		goto nla_put_failure;



	nest = nla_nest_start(skb, NFTA_FLOWTABLE_HOOK);

	if (!nest)

		goto nla_put_failure;

	if (nla_put_be32(skb, NFTA_FLOWTABLE_HOOK_NUM, htonl(flowtable->hooknum)) ||

	    nla_put_be32(skb, NFTA_FLOWTABLE_HOOK_PRIORITY, htonl(flowtable->priority)))

		goto nla_put_failure;