Commit d393cc60 authored Dec 21, 2018 by Nicolas Saenz Julienne Committed by Greg Kroah-Hartman Dec 05, 2019

firmware: arm_sdei: fix wrong of_node_put() in init function



[ Upstream commit c3790b3799f8d75d93d26f6fd7bb569fc8c8b0cb ]

After finding a "firmware" dt node arm_sdei tries to match it's
compatible string with it. To do so it's calling of_find_matching_node()
which already takes care of decreasing the refcount on the "firmware"
node. We are then incorrectly decreasing the refcount on that node
again.

This patch removes the unwarranted call to of_node_put().

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 77a9b90d

drivers/firmware/arm_sdei.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1017,7 +1017,6 @@ static bool __init sdei_present_dt(void)
		return false;

		np = of_find_matching_node(fw_np, sdei_of_match);
		of_node_put(fw_np);
		if (!np)
		return false;