Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d384e65f authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Pablo Neira Ayuso
Browse files

netfilter: return booleans instead of integers 



Return statements in functions returning bool should use
true/false instead of 1/0.

These issues were detected with the help of Coccinelle.

Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 3ecbfd65

net/netfilter/nf_conncount.c

+1 −1
Original line number Diff line number Diff line
@@ -71,7 +71,7 @@ static inline bool already_closed(const struct nf_conn *conn) 
		return conn->proto.tcp.state == TCP_CONNTRACK_TIME_WAIT ||

		       conn->proto.tcp.state == TCP_CONNTRACK_CLOSE;

	else

		return 0;

		return false;

}



static int key_diff(const u32 *a, const u32 *b, unsigned int klen)

net/netfilter/xt_hashlimit.c

+1 −1
Original line number Diff line number Diff line
@@ -353,7 +353,7 @@ static int htable_create(struct net *net, struct hashlimit_cfg3 *cfg, 
static bool select_all(const struct xt_hashlimit_htable *ht,

		       const struct dsthash_ent *he)

{

	return 1;

	return true;

}



static bool select_gc(const struct xt_hashlimit_htable *ht,

net/netfilter/xt_ipcomp.c

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ static bool comp_mt(const struct sk_buff *skb, struct xt_action_param *par) 
		 */

		pr_debug("Dropping evil IPComp tinygram.\n");

		par->hotdrop = true;

		return 0;

		return false;

	}



	return spi_match(compinfo->spis[0], compinfo->spis[1],